From: Peter Zijlstra Date: Mon, 30 May 2022 07:45:38 +0000 (+0200) Subject: sched/autogroup: Fix sysctl move X-Git-Tag: v6.1-rc5~1126^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=82f586f923e3ac6062bc7867717a7f8afc09e0ff;p=platform%2Fkernel%2Flinux-starfive.git sched/autogroup: Fix sysctl move Ivan reported /proc/sys/kernel/sched_autogroup_enabled went walk-about and using the noautogroup command line parameter would result in a boot error message. Turns out the sysctl move placed the init function wrong. Fixes: c8eaf6ac76f4 ("sched: move autogroup sysctls into its own file") Reported-by: Ivan Kozik Signed-off-by: Peter Zijlstra (Intel) Tested-by: Ivan Kozik Link: https://lkml.kernel.org/r/YpR2IqndgsyMzN00@worktop.programming.kicks-ass.net --- diff --git a/kernel/sched/autogroup.c b/kernel/sched/autogroup.c index 16092b4..4ebaf97 100644 --- a/kernel/sched/autogroup.c +++ b/kernel/sched/autogroup.c @@ -36,6 +36,7 @@ void __init autogroup_init(struct task_struct *init_task) kref_init(&autogroup_default.kref); init_rwsem(&autogroup_default.lock); init_task->signal->autogroup = &autogroup_default; + sched_autogroup_sysctl_init(); } void autogroup_free(struct task_group *tg) @@ -219,7 +220,6 @@ void sched_autogroup_exit(struct signal_struct *sig) static int __init setup_autogroup(char *str) { sysctl_sched_autogroup_enabled = 0; - sched_autogroup_sysctl_init(); return 1; }