From: Andrew Scull <ascull@google.com>
Date: Mon, 16 May 2022 10:41:35 +0000 (+0000)
Subject: test: dm: virtio: Test notify before del_vqs
X-Git-Tag: v2022.10~89^2~24^2~5
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=82c8610a44c6d4d38b90246f6893cb8e7b911e0c;p=platform%2Fkernel%2Fu-boot.git

test: dm: virtio: Test notify before del_vqs

The virtqueue is passed to virtio_notify() so move the virtqueue
deletion to the end of the test when it's no longer needed. This wasn't
causing any problems because the sandbox virtio transport driver doesn't
do anything for notifications, but it could cause problems if things
change and it was a bad example.

Signed-off-by: Andrew Scull <ascull@google.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

diff --git a/test/dm/virtio.c b/test/dm/virtio.c
index aa4e3d7..ff1dea3 100644
--- a/test/dm/virtio.c
+++ b/test/dm/virtio.c
@@ -80,8 +80,8 @@ static int dm_test_virtio_all_ops(struct unit_test_state *uts)
 	ut_asserteq_64(BIT_ULL(VIRTIO_F_VERSION_1), features);
 	ut_assertok(virtio_set_features(dev));
 	ut_assertok(virtio_find_vqs(dev, nvqs, vqs));
-	ut_assertok(virtio_del_vqs(dev));
 	ut_assertok(virtio_notify(dev, vqs[0]));
+	ut_assertok(virtio_del_vqs(dev));
 
 	return 0;
 }