From: jkummerow@chromium.org Date: Wed, 31 Aug 2011 13:01:28 +0000 (+0000) Subject: Add tools/presubmit.py call to tools/test-wrapper-gypbuild.py X-Git-Tag: upstream/4.7.83~18606 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=829e174a02549302ebf215080965ed62ce6ddaef;p=platform%2Fupstream%2Fv8.git Add tools/presubmit.py call to tools/test-wrapper-gypbuild.py Review URL: http://codereview.chromium.org/7785025 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9081 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- diff --git a/Makefile b/Makefile index 3008779..618bbef 100644 --- a/Makefile +++ b/Makefile @@ -98,8 +98,9 @@ CHECKS = $(addsuffix .check,$(BUILDS)) # File where previously used GYPFLAGS are stored. ENVFILE = $(OUTDIR)/environment -.PHONY: all clean $(ENVFILE).new \ - $(ARCHES) $(MODES) $(BUILDS) $(addsuffix .clean,$(ARCHES)) +.PHONY: all check clean $(ENVFILE).new \ + $(ARCHES) $(MODES) $(BUILDS) $(CHECKS) $(addsuffix .clean,$(ARCHES)) \ + $(addsuffix .check,$(MODES)) $(addsuffix .check,$(ARCHES)) # Target definitions. "all" is the default. all: $(MODES) diff --git a/tools/test-wrapper-gypbuild.py b/tools/test-wrapper-gypbuild.py index 9bc6bf6..fdf8257 100755 --- a/tools/test-wrapper-gypbuild.py +++ b/tools/test-wrapper-gypbuild.py @@ -53,6 +53,9 @@ def BuildOptions(): result.add_option("--outdir", help='Base output directory', default='out') + result.add_option("--no-presubmit", + help='Skip presubmit checks', + default=False, action="store_true") # Flags this wrapper script handles itself: result.add_option("-m", "--mode", @@ -202,6 +205,11 @@ def Main(): return 1 workspace = abspath(join(dirname(sys.argv[0]), '..')) + + if not options.no_presubmit: + print ">>> running presubmit tests" + subprocess.call([workspace + '/tools/presubmit.py']) + args_for_children = [workspace + '/tools/test.py'] + PassOnOptions(options) args_for_children += ['--no-build', '--build-system=gyp'] for arg in args: