From: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Date: Sun, 18 Aug 2013 19:21:57 +0000 (-0700)
Subject: rcu: Fix dubious "if" condition in __call_rcu_nocb_enqueue()
X-Git-Tag: v3.13-rc1~152^2^2~3^2~7
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=829511d8aa7a2179bba57ab4ab277d6f9c77ae5b;p=kernel%2Fkernel-generic.git

rcu: Fix dubious "if" condition in __call_rcu_nocb_enqueue()

This commit replaces an incorrect (but fortunately functional)
bitwise OR ("|") operator with the correct logical OR ("||").

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---

diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h
index 130c97b..6f9aece 100644
--- a/kernel/rcutree_plugin.h
+++ b/kernel/rcutree_plugin.h
@@ -2108,7 +2108,7 @@ static void __call_rcu_nocb_enqueue(struct rcu_data *rdp,
 
 	/* If we are not being polled and there is a kthread, awaken it ... */
 	t = ACCESS_ONCE(rdp->nocb_kthread);
-	if (rcu_nocb_poll | !t)
+	if (rcu_nocb_poll || !t)
 		return;
 	len = atomic_long_read(&rdp->nocb_q_count);
 	if (old_rhpp == &rdp->nocb_head) {