From: Peter Huewe Date: Thu, 14 Feb 2013 21:27:06 +0000 (+0100) Subject: staging/comedi: Use && instead of & for logical comparision X-Git-Tag: v3.9-rc1~127^2~37 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8289ad0578ad7e66b2052754746b4deb1a88cc4a;p=profile%2Fivi%2Fkernel-x86-ivi.git staging/comedi: Use && instead of & for logical comparision sparse complains that: drivers/staging/comedi/drivers/adl_pci9118.c:813 pci9118_calc_divisors() warn: maybe use && instead of & usessh is used as a boolean flag (0 and 1) and is compared to a boolean value so we should use && here. Signed-off-by: Peter Huewe Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c index ef4dbe5..4dbac74 100644 --- a/drivers/staging/comedi/drivers/adl_pci9118.c +++ b/drivers/staging/comedi/drivers/adl_pci9118.c @@ -810,7 +810,7 @@ static void pci9118_calc_divisors(char mode, struct comedi_device *dev, *tim2 = *div1 * devpriv->i8254_osc_base; /* real convert timer */ - if (usessh & (chnsshfront == 0)) /* use BSSH signal */ + if (usessh && (chnsshfront == 0)) /* use BSSH signal */ if (*div2 < (chans + 2)) *div2 = chans + 2;