From: Marcel Holtmann <marcel@holtmann.org>
Date: Sat, 5 Jan 2013 04:28:07 +0000 (-0800)
Subject: gdbus: Check signature of property value before calling setter
X-Git-Tag: 1.11~43
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=827a60776641779d5089ce9dda8fc3c8bd027802;p=platform%2Fupstream%2Fconnman.git

gdbus: Check signature of property value before calling setter
---

diff --git a/gdbus/object.c b/gdbus/object.c
index e569acb..688cd05 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -896,6 +896,11 @@ static DBusMessage *properties_set(DBusConnection *connection,
 						DBUS_ERROR_UNKNOWN_PROPERTY,
 						"No such property '%s'", name);
 
+	if (strcmp(dbus_message_iter_get_signature(&sub), property->type))
+		return g_dbus_create_error(message,
+					DBUS_ERROR_INVALID_SIGNATURE,
+					"Invalid signature for '%s'", name);
+
 	propdata = g_new(struct property_data, 1);
 	propdata->id = next_pending_property++;
 	propdata->message = dbus_message_ref(message);