From: Helge Deller Date: Thu, 17 Feb 2022 12:12:39 +0000 (+0100) Subject: parisc: Reduce code size by optimizing get_current() function calls X-Git-Tag: v6.6.17~8003^2~13 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8278cc16266326f23c05f94d748569faa81319bb;p=platform%2Fkernel%2Flinux-rpi.git parisc: Reduce code size by optimizing get_current() function calls The get_current() code uses the mfctl() macro to get the pointer to the current task struct from %cr30. The problem with the mfctl() macro is, that it is marked volatile which is basically correct, because mfctl() is used to get e.g. the current internal timer or interrupt flags as well. But specifically the task struct pointer (%cr30) doesn't change over time when the kernel executes code for a task. So, by dropping the volatile when retrieving %cr30 the compiler is now able to get this value only once and optimize the generated code a lot. A bloat-o-meter comparism shows that this patch saves ~5kB kernel code on a 32-bit kernel and ~6kB kernel code on a 64-bit kernel. Signed-off-by: Helge Deller --- diff --git a/arch/parisc/include/asm/current.h b/arch/parisc/include/asm/current.h index 568b739..dc7aea07 100644 --- a/arch/parisc/include/asm/current.h +++ b/arch/parisc/include/asm/current.h @@ -2,14 +2,16 @@ #ifndef _ASM_PARISC_CURRENT_H #define _ASM_PARISC_CURRENT_H -#include - #ifndef __ASSEMBLY__ struct task_struct; static __always_inline struct task_struct *get_current(void) { - return (struct task_struct *) mfctl(30); + struct task_struct *ts; + + /* do not use mfctl() macro as it is marked volatile */ + asm( "mfctl %%cr30,%0" : "=r" (ts) ); + return ts; } #define current get_current()