From: Donglin Peng Date: Sun, 20 Aug 2017 05:55:13 +0000 (+0800) Subject: ASoC: sun4i-codec: Remove unnecessary function call X-Git-Tag: v4.14-rc4~21^2~23^2~3^6~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=827807549e690c84bba5aac99b58dfbd52fcef8c;p=platform%2Fkernel%2Flinux-rpi.git ASoC: sun4i-codec: Remove unnecessary function call First of all,the address of pdev->dev is assigned to card->dev in create_card,then the function platform_set_drvdata copies the value the variable card to pdev->dev.driver_data, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will also do the same copy operation,so i think that the former copy operation can be removed. Signed-off-by: Peng Donglin Signed-off-by: Mark Brown --- diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c index c668b8b..baa9007 100644 --- a/sound/soc/sunxi/sun4i-codec.c +++ b/sound/soc/sunxi/sun4i-codec.c @@ -1655,7 +1655,6 @@ static int sun4i_codec_probe(struct platform_device *pdev) goto err_unregister_codec; } - platform_set_drvdata(pdev, card); snd_soc_card_set_drvdata(card, scodec); ret = snd_soc_register_card(card);