From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 14 Mar 2018 20:08:28 +0000 (+0300)
Subject: of: unittest: fix an error code in of_unittest_apply_overlay()
X-Git-Tag: v4.19~1284^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=827473268ee492b30b576ef156ab524a2b9f3520;p=platform%2Fkernel%2Flinux-rpi3.git

of: unittest: fix an error code in of_unittest_apply_overlay()

We accidentally return zero on failure instead of a negative error code.

Fixes: 39a751a4cb7e ("of: change overlay apply input data from unflattened to FDT")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index a08c9e2..02c5984 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -1423,15 +1423,13 @@ static int __init of_unittest_apply_overlay(int overlay_nr, int unittest_nr,
 		int *overlay_id)
 {
 	const char *overlay_name;
-	int ret;
 
 	overlay_name = overlay_name_from_nr(overlay_nr);
 
-	ret = overlay_data_apply(overlay_name, overlay_id);
-	if (!ret) {
+	if (!overlay_data_apply(overlay_name, overlay_id)) {
 		unittest(0, "could not apply overlay \"%s\"\n",
 				overlay_name);
-		return ret;
+		return -EFAULT;
 	}
 	of_unittest_track_overlay(*overlay_id);