From: Vitaly Buka Date: Sun, 27 Nov 2022 19:50:50 +0000 (-0800) Subject: [test][asan] Check find_bad_address test X-Git-Tag: upstream/17.0.6~26285 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8226ec0e4c451f79838d0c719bcfcabd7c09898e;p=platform%2Fupstream%2Fllvm.git [test][asan] Check find_bad_address test For consistency with future TestDoubleEndedContainer, where calculation of the expected bad address is complicated. --- diff --git a/compiler-rt/test/asan/TestCases/contiguous_container.cpp b/compiler-rt/test/asan/TestCases/contiguous_container.cpp index d2b7d4c..ee56f2a 100644 --- a/compiler-rt/test/asan/TestCases/contiguous_container.cpp +++ b/compiler-rt/test/asan/TestCases/contiguous_container.cpp @@ -3,6 +3,8 @@ // Test __sanitizer_annotate_contiguous_container. #include +#include + #include #include #include @@ -16,6 +18,20 @@ template static constexpr T RoundDown(T x) { ~(kGranularity - 1)); } +static std::vector GetPoisonedMask(char *begin, char *end) { + std::vector result; + result.reserve(end - begin); + for (; begin != end; ++begin) + result.push_back(__asan_address_is_poisoned(begin)); + return result; +} + +static int GetFirstMissmatch(const std::vector &a, + const std::vector &b) { + return std::mismatch(a.begin(), a.end(), b.begin(), b.end()).first - + a.begin(); +} + void TestContainer(size_t capacity, size_t off_begin, bool poison_buffer) { size_t buffer_size = capacity + off_begin + kGranularity * 2; char *buffer = new char[buffer_size]; @@ -49,6 +65,14 @@ void TestContainer(size_t capacity, size_t off_begin, bool poison_buffer) { assert(__asan_address_is_poisoned(cur) == poison_buffer); } + // Precalculate masks. + std::vector> masks(capacity + 1); + for (int i = 0; i <= capacity; i++) { + char *old_end = end; + end = st_beg + i; + __sanitizer_annotate_contiguous_container(st_beg, st_end, old_end, end); + masks[i] = GetPoisonedMask(st_beg, st_end); + } for (int i = 0; i <= capacity; i++) { char *old_end = end; end = st_beg + i; @@ -62,20 +86,18 @@ void TestContainer(size_t capacity, size_t off_begin, bool poison_buffer) { const void *bad_address = __sanitizer_contiguous_container_find_bad_address(st_beg, cur, st_end); - if (cur == end || - // Any end in the last unaligned granule is OK, if bytes after the - // storage are not poisoned. + // The last unaligned granule of the storage followed by unpoisoned + // bytes looks the same. (!poison_buffer && RoundDown(st_end) <= std::min(cur, end))) { assert(is_valid); assert(!bad_address); - } else if (cur < end) { - assert(!is_valid); - assert(cur == bad_address); - } else { - assert(!is_valid); - assert(end == bad_address); + continue; } + assert(!is_valid); + assert(bad_address == std::min(cur, end)); + assert(bad_address == + st_beg + GetFirstMissmatch(masks[i], masks[cur - st_beg])); } }