From: Martin Fleisz <martin.fleisz@thincast.com>
Date: Tue, 20 Aug 2019 08:07:10 +0000 (+0200)
Subject: client/common: Remove incorrect prompt for creds parsing (#5528)
X-Git-Tag: 2.0.0~373
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=81cb0a7ee5a709a58234255eb90ec7eae284f663;p=platform%2Fupstream%2Ffreerdp.git

client/common: Remove incorrect prompt for creds parsing (#5528)

"prompt for credentials on client" was incorrectly merged together with
"prompt for credentials" into a single setting. However the first option
determines if the client should prompt for credentials if the remote
server does not support server authentication. "prompt for credentials"
on the other hand determines if the client should use any previously
stored credentials or if it should always prompt for them.
---

diff --git a/client/common/file.c b/client/common/file.c
index f3f31ad..8808271 100644
--- a/client/common/file.c
+++ b/client/common/file.c
@@ -310,8 +310,7 @@ static BOOL freerdp_client_rdp_file_set_integer(rdpFile* file, const char* name,
 		file->AuthenticationLevel = (UINT32)value;
 	else if (_stricmp(name, "promptcredentialonce") == 0)
 		file->PromptCredentialOnce = (UINT32)value;
-	else if ((_stricmp(name, "prompt for credentials") == 0) ||
-	         (_stricmp(name, "prompt for credentials on client") == 0))
+	else if ((_stricmp(name, "prompt for credentials") == 0))
 		file->PromptForCredentials = (UINT32)value;
 	else if (_stricmp(name, "negotiate security layer") == 0)
 		file->NegotiateSecurityLayer = (UINT32)value;