From: Yufen Yu Date: Mon, 24 May 2021 09:35:21 +0000 (-0400) Subject: ASoC: img: Fix PM reference leak in img_i2s_in_probe() X-Git-Tag: v5.15~539^2~25^2~93 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=81aad47278539f02de808bcc8251fed0ad3d6f55;p=platform%2Fkernel%2Flinux-starfive.git ASoC: img: Fix PM reference leak in img_i2s_in_probe() pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Yufen Yu Link: https://lore.kernel.org/r/20210524093521.612176-1-yuyufen@huawei.com Signed-off-by: Mark Brown --- diff --git a/sound/soc/img/img-i2s-in.c b/sound/soc/img/img-i2s-in.c index 0843235..fd3432a 100644 --- a/sound/soc/img/img-i2s-in.c +++ b/sound/soc/img/img-i2s-in.c @@ -464,7 +464,7 @@ static int img_i2s_in_probe(struct platform_device *pdev) if (ret) goto err_pm_disable; } - ret = pm_runtime_get_sync(&pdev->dev); + ret = pm_runtime_resume_and_get(&pdev->dev); if (ret < 0) goto err_suspend;