From: Gao Xiang <hsiangkao@linux.alibaba.com>
Date: Fri, 2 Aug 2024 01:55:27 +0000 (+0800)
Subject: erofs-utils: lib: fix fd leak on failure in erofs_dev_open()
X-Git-Tag: v1.8~11
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=812339932cd46791084bd877a30c96ff728c707e;p=platform%2Fupstream%2Ferofs-utils.git

erofs-utils: lib: fix fd leak on failure in erofs_dev_open()

Coverity-id: 502356
Reviewed-by: Sandeep Dhavale <dhavale@google.com>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Link: https://lore.kernel.org/r/20240802015527.2113797-3-hsiangkao@linux.alibaba.com
---

diff --git a/lib/io.c b/lib/io.c
index 4937db5..6bfae69 100644
--- a/lib/io.c
+++ b/lib/io.c
@@ -258,8 +258,10 @@ repeat:
 #if defined(HAVE_SYS_STATFS_H) && defined(HAVE_FSTATFS)
 			struct statfs stfs;
 
-			if (again)
+			if (again) {
+				close(fd);
 				return -ENOTEMPTY;
+			}
 
 			/*
 			 * fses like EXT4 and BTRFS will flush dirty blocks