From: Chris Wilson Date: Sun, 18 Dec 2016 15:37:18 +0000 (+0000) Subject: drm/i915: Add a reminder that i915_vma_move_to_active() requires struct_mutex X-Git-Tag: v4.14-rc1~674^2~37^2~634 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=81147b07f27600925fb7af1390686830abbc6034;p=platform%2Fkernel%2Flinux-rpi3.git drm/i915: Add a reminder that i915_vma_move_to_active() requires struct_mutex i915_vma_move_to_active() requires the struct_mutex for serialisation with retirement, so mark it up with lockdep_assert_held(). Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin Link: http://patchwork.freedesktop.org/patch/msgid/20161218153724.8439-1-chris@chris-wilson.co.uk --- diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c index d665a33..c64438f 100644 --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c @@ -1259,6 +1259,7 @@ void i915_vma_move_to_active(struct i915_vma *vma, struct drm_i915_gem_object *obj = vma->obj; const unsigned int idx = req->engine->id; + lockdep_assert_held(&req->i915->drm.struct_mutex); GEM_BUG_ON(!drm_mm_node_allocated(&vma->node)); /* Add a reference if we're newly entering the active list.