From: Colin Ian King <colin.king@canonical.com>
Date: Sat, 11 May 2019 13:48:13 +0000 (+0100)
Subject: staging: vc04_services: bcm2835-camera: remove redundant assignment to variable ret
X-Git-Tag: v5.15~5977^2~504
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=80ff4ad4c62f7b7694327712f1aaf5a38eae4a61;p=platform%2Fkernel%2Flinux-starfive.git

staging: vc04_services: bcm2835-camera: remove redundant assignment to variable ret

The variable ret is being initialized however this is never read and later
it is being reassigned to a new value. The initialization is redundant and
hence can be removed.

Addresses-Coverity: ("Unused Value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c
index 9841c30..74410fe 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/controls.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c
@@ -579,7 +579,7 @@ static int ctrl_set_colfx(struct bm2835_mmal_dev *dev,
 			  struct v4l2_ctrl *ctrl,
 			  const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
 {
-	int ret = -EINVAL;
+	int ret;
 	struct vchiq_mmal_port *control;
 
 	control = &dev->component[MMAL_COMPONENT_CAMERA]->control;