From: Piotr Kosko Date: Thu, 26 Mar 2020 07:41:59 +0000 (+0100) Subject: [Alarm] Fixed Coverity issue and undefined behaviour X-Git-Tag: submit/tizen/20200508.122743~6^2^2^2^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=80f06ab362ec4ddda48eaa5374ce41ccd3478735;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git [Alarm] Fixed Coverity issue and undefined behaviour [Coverity] 1134493 Change-Id: I3c9aa41a640efc6ca001ea96978374994a88e029 --- diff --git a/src/alarm/alarm_manager.cc b/src/alarm/alarm_manager.cc index c9690ce1..7a231819 100644 --- a/src/alarm/alarm_manager.cc +++ b/src/alarm/alarm_manager.cc @@ -365,7 +365,11 @@ PlatformResult AlarmManager::GetAlarm(int id, picojson::object& obj) { int interval = 0; - app_control_get_extra_data(app_control, kAlarmAbsoluteRecurrenceTypeKey, &alarm_type); + ret = app_control_get_extra_data(app_control, kAlarmAbsoluteRecurrenceTypeKey, &alarm_type); + if (APP_CONTROL_ERROR_NONE != ret) { + return LogAndCreateResult(ErrorCode::UNKNOWN_ERR, "Unknown error occurred.", + ("Getting data failed: %d (%s)", ret, get_error_message(ret))); + } if (!strcmp(alarm_type, kAlarmAbsoluteReccurrenceTypeInterval)) { ret = alarm_get_scheduled_period(id, &interval);