From: Takashi Iwai Date: Mon, 9 Jan 2012 10:37:20 +0000 (+0100) Subject: ALSA: usb-audio - Avoid flood of frame-active debug messages X-Git-Tag: upstream/snapshot3+hdmi~7307^2~117^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=80c8a2a372599e604b04a9c568952fe39cd1851d;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git ALSA: usb-audio - Avoid flood of frame-active debug messages With some buggy devices, the usb-audio driver may give "frame xxx active" kernel messages too often. Better to keep it as debug-only using snd_printdd(), and also add the rate-limit for avoiding floods. Bugzilla: https://bugzilla.novell.com/show_bug.cgi?id=738681 Cc: Signed-off-by: Takashi Iwai --- diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c index 81c6ede..08dcce5 100644 --- a/sound/usb/endpoint.c +++ b/sound/usb/endpoint.c @@ -17,6 +17,7 @@ #include #include +#include #include #include @@ -458,8 +459,8 @@ static int retire_capture_urb(struct snd_usb_substream *subs, for (i = 0; i < urb->number_of_packets; i++) { cp = (unsigned char *)urb->transfer_buffer + urb->iso_frame_desc[i].offset; - if (urb->iso_frame_desc[i].status) { - snd_printd(KERN_ERR "frame %d active: %d\n", i, urb->iso_frame_desc[i].status); + if (urb->iso_frame_desc[i].status && printk_ratelimit()) { + snd_printdd("frame %d active: %d\n", i, urb->iso_frame_desc[i].status); // continue; } bytes = urb->iso_frame_desc[i].actual_length;