From: Edward Hervey Date: Mon, 9 Feb 2009 10:57:16 +0000 (+0100) Subject: pre-commit.hook: Use the file content from the index. X-Git-Tag: upstream/20130618~250 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=80c627dfabb45c3f40727dce755c81bed1e38e3d;p=platform%2Fupstream%2Fgst-common.git pre-commit.hook: Use the file content from the index. Issue reported by Jonas Holmberg on #gstreamer --- diff --git a/hooks/pre-commit.hook b/hooks/pre-commit.hook index a1d7502..a896fa4 100755 --- a/hooks/pre-commit.hook +++ b/hooks/pre-commit.hook @@ -20,18 +20,20 @@ INDENT_PARAMETERS="--braces-on-if-line \ echo "--Checking style--" for file in `git-diff-index --cached --name-only HEAD | grep "\.c$"` ; do - test -f ${file} || continue - tempfoo=`basename $0` - newfile=`mktemp /tmp/${tempfoo}.XXXXXX` || exit 1 + # nf is the temporary checkout. This makes sure we check against the + # revision in the index (and not the checked out version). + nf=`git checkout-index --temp ${file} | cut -f 1` + newfile=`mktemp /tmp/${nf}.XXXXXX` || exit 1 indent ${INDENT_PARAMETERS} \ - $file -o $newfile 2>> /dev/null + $nf -o $newfile 2>> /dev/null # FIXME: Call indent twice as it tends to do line-breaks # different for every second call. indent ${INDENT_PARAMETERS} \ $newfile 2>> /dev/null - diff -u -p "${file}" "${newfile}" + diff -u -p "${nf}" "${newfile}" r=$? rm "${newfile}" + rm "${nf}" if [ $r != 0 ] ; then echo "Code style error in $file, please fix before commiting." exit 1