From: Jean-Philippe Andre Date: Tue, 7 Nov 2017 05:59:01 +0000 (+0900) Subject: elm: Fix make check (code_widget) X-Git-Tag: submit/sandbox/upgrade/efl120/20180319.053334~1839 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=80b0ef75374e0cd0c9b6aa657cbf3e819065da5f;p=platform%2Fupstream%2Fefl.git elm: Fix make check (code_widget) elm_code_widget is causing a lot of trouble as it's relying on internal access to elementary, without being built as part of elementary.so. Many EAPI symbols are exported that shouldn't need to be, as they are only internals of elm. --- diff --git a/src/lib/elementary/elm_widget.c b/src/lib/elementary/elm_widget.c index 022f1f3..cf0e8fd 100644 --- a/src/lib/elementary/elm_widget.c +++ b/src/lib/elementary/elm_widget.c @@ -53,7 +53,8 @@ typedef struct _Elm_Event_Cb_Data Elm_Event_Cb_Data; typedef struct _Elm_Label_Data Elm_Label_Data; typedef struct _Elm_Translate_String_Data Elm_Translate_String_Data; -Eina_Bool _elm_legacy_add = EINA_FALSE; +/* FIXME: EAPI because of elm_code_widget test case */ +EAPI Eina_Bool _elm_legacy_add = EINA_FALSE; struct _Elm_Event_Cb_Data { diff --git a/src/lib/elementary/elm_widget.h b/src/lib/elementary/elm_widget.h index aa5d11d..45f5d93 100644 --- a/src/lib/elementary/elm_widget.h +++ b/src/lib/elementary/elm_widget.h @@ -811,7 +811,7 @@ _elm_widget_sub_object_redirect_to_top(Evas_Object *obj, Evas_Object *sobj) /* Internal hack to mark legacy objects as such before construction. * No need for TLS: Only UI objects created in the main loop matter. */ -extern Eina_Bool _elm_legacy_add; +EAPI Eina_Bool _elm_legacy_add; #define elm_legacy_add(k, p, ...) ({ _elm_legacy_add = 1; \ efl_add(k, p, efl_canvas_object_legacy_ctor(efl_added), ##__VA_ARGS__); })