From: Sachin Kamat Date: Mon, 4 Mar 2013 09:09:39 +0000 (+0530) Subject: gpio/vt8500: Convert to devm_ioremap_resource() X-Git-Tag: v3.10-rc1~78^2~34 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=808c513ee64be7cec6a7dcfff1687bc0995362bc;p=profile%2Fivi%2Fkernel-x86-ivi.git gpio/vt8500: Convert to devm_ioremap_resource() Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat Reviewed-by: Thierry Reding Acked-by: Tony Prisk Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpio-vt8500.c b/drivers/gpio/gpio-vt8500.c index 81683ca..b2d8d6f 100644 --- a/drivers/gpio/gpio-vt8500.c +++ b/drivers/gpio/gpio-vt8500.c @@ -309,11 +309,9 @@ static int vt8500_gpio_probe(struct platform_device *pdev) return -ENODEV; } - gpio_base = devm_request_and_ioremap(&pdev->dev, res); - if (!gpio_base) { - dev_err(&pdev->dev, "Unable to map GPIO registers\n"); - return -ENOMEM; - } + gpio_base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(gpio_base)) + return PTR_ERR(gpio_base); ret = vt8500_add_chips(pdev, gpio_base, of_id->data);