From: MyungJoo Ham <myungjoo.ham@samsung.com>
Date: Mon, 3 Dec 2018 00:56:47 +0000 (+0900)
Subject: [Decoder] Coverity issue 1036581 fix
X-Git-Tag: v0.0.3~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=808b29e3b47d53acf18343721e4f5661f79a4ed5;p=platform%2Fupstream%2Fnnstreamer.git

[Decoder] Coverity issue 1036581 fix

Coverity wants to check the return value of
_tensordec_process_plugin_options.

Let't check and log if there is an unwanted return value.

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
---

diff --git a/gst/tensor_decoder/tensordec.c b/gst/tensor_decoder/tensordec.c
index a9961f6..5f83196 100644
--- a/gst/tensor_decoder/tensordec.c
+++ b/gst/tensor_decoder/tensordec.c
@@ -398,6 +398,7 @@ gst_tensordec_set_property (GObject * object, guint prop_id,
     case PROP_MODE:{
       int i;
       TensorDecDef *decoder;
+      gboolean retval = TRUE;
       temp_string = g_value_dup_string (value);
       decoder = tensordec_find (temp_string);
 
@@ -425,7 +426,10 @@ gst_tensordec_set_property (GObject * object, guint prop_id,
 
         silent_debug ("tensor_decoder plugin mode (%s)\n", temp_string);
         for (i = 0; i < TensorDecMaxOpNum; i++)
-          _tensordec_process_plugin_options (self, i);
+          retval &= _tensordec_process_plugin_options (self, i);
+        if (FALSE == retval)
+          GST_WARNING_OBJECT (self,
+              "One or more option has failed to configure while setting the mode.");
         self->mode = DECODE_MODE_PLUGIN;
         self->output_type = self->decoder->type;
       } else {