From: Matthias Kaehlcke Date: Tue, 9 Jul 2019 22:44:50 +0000 (-0700) Subject: Bluetooth: btqca: Add a short delay before downloading the NVM X-Git-Tag: v5.15~5684^2~9^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8059ba0bd0e4694e51c2ee6438a77b325f06c0d5;p=platform%2Fkernel%2Flinux-starfive.git Bluetooth: btqca: Add a short delay before downloading the NVM On WCN3990 downloading the NVM sometimes fails with a "TLV response size mismatch" error: [ 174.949955] Bluetooth: btqca.c:qca_download_firmware() hci0: QCA Downloading qca/crnv21.bin [ 174.958718] Bluetooth: btqca.c:qca_tlv_send_segment() hci0: QCA TLV response size mismatch It seems the controller needs a short time after downloading the firmware before it is ready for the NVM. A delay as short as 1 ms seems sufficient, make it 10 ms just in case. No event is received during the delay, hence we don't just silently drop an extra event. Signed-off-by: Matthias Kaehlcke Signed-off-by: Marcel Holtmann --- diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c index 8b33128..c59ca57 100644 --- a/drivers/bluetooth/btqca.c +++ b/drivers/bluetooth/btqca.c @@ -388,6 +388,9 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, return err; } + /* Give the controller some time to get ready to receive the NVM */ + msleep(10); + /* Download NVM configuration */ config.type = TLV_TYPE_NVM; if (firmware_name)