From: Michael Ellerman Date: Mon, 14 May 2018 12:50:31 +0000 (+1000) Subject: powerpc/io: Add __raw_writeq_be() __raw_rm_writeq_be() X-Git-Tag: v5.15~8686^2~165 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8056fe28d04607106e7d418bd9ee2e63562def50;p=platform%2Fkernel%2Flinux-starfive.git powerpc/io: Add __raw_writeq_be() __raw_rm_writeq_be() Add byte-swapping versions of __raw_writeq() and __raw_rm_writeq(). This allows us to avoid sparse warnings caused by passing __be64 to __raw_writeq(), which takes unsigned long: arch/powerpc/platforms/powernv/pci-ioda.c:1981:38: warning: incorrect type in argument 1 (different base types) expected unsigned long [unsigned] v got restricted __be64 [usertype] It's also generally preferable to use a byte-swapping accessor rather than doing it by hand in the code, which is more bug prone. Signed-off-by: Michael Ellerman Reviewed-by: Samuel Mendoza-Jonas --- diff --git a/arch/powerpc/include/asm/io.h b/arch/powerpc/include/asm/io.h index af07492..e0331e7 100644 --- a/arch/powerpc/include/asm/io.h +++ b/arch/powerpc/include/asm/io.h @@ -367,6 +367,11 @@ static inline void __raw_writeq(unsigned long v, volatile void __iomem *addr) *(volatile unsigned long __force *)PCI_FIX_ADDR(addr) = v; } +static inline void __raw_writeq_be(unsigned long v, volatile void __iomem *addr) +{ + __raw_writeq((__force unsigned long)cpu_to_be64(v), addr); +} + /* * Real mode versions of the above. Those instructions are only supposed * to be used in hypervisor real mode as per the architecture spec. @@ -395,6 +400,11 @@ static inline void __raw_rm_writeq(u64 val, volatile void __iomem *paddr) : : "r" (val), "r" (paddr) : "memory"); } +static inline void __raw_rm_writeq_be(u64 val, volatile void __iomem *paddr) +{ + __raw_rm_writeq((__force u64)cpu_to_be64(val), paddr); +} + static inline u8 __raw_rm_readb(volatile void __iomem *paddr) { u8 ret;