From: Larry Finger <Larry.Finger@lwfinger.net>
Date: Sat, 5 Nov 2016 19:08:57 +0000 (-0500)
Subject: ssb: Fix error routine when fallback SPROM fails
X-Git-Tag: v4.10-rc1~202^2~118^2~72
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8052d7245b6089992343c80b38b14dbbd8354651;p=platform%2Fkernel%2Flinux-exynos.git

ssb: Fix error routine when fallback SPROM fails

When there is a CRC error in the SPROM read from the device, the code
attempts to handle a fallback SPROM. When this also fails, the driver
returns zero rather than an error code.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Stable <stable@vger.kernel.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
---

diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
index 0f28c08..77b551d 100644
--- a/drivers/ssb/pci.c
+++ b/drivers/ssb/pci.c
@@ -909,6 +909,7 @@ static int ssb_pci_sprom_get(struct ssb_bus *bus,
 			if (err) {
 				ssb_warn("WARNING: Using fallback SPROM failed (err %d)\n",
 					 err);
+				goto out_free;
 			} else {
 				ssb_dbg("Using SPROM revision %d provided by platform\n",
 					sprom->revision);