From: Thibault Saunier <tsaunier@igalia.com>
Date: Wed, 27 May 2020 23:39:49 +0000 (-0400)
Subject: xml-formatter: Add an GST_ERROR when setting control sources fails
X-Git-Tag: 1.19.3~493^2~148
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8047323e931309d09d3697f0a4848b6043a72f83;p=platform%2Fupstream%2Fgstreamer.git

xml-formatter: Add an GST_ERROR when setting control sources fails

CID 1463853

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/180>
---

diff --git a/ges/ges-base-xml-formatter.c b/ges/ges-base-xml-formatter.c
index d9149cc..7239ba6 100644
--- a/ges/ges-base-xml-formatter.c
+++ b/ges/ges-base-xml-formatter.c
@@ -1115,8 +1115,11 @@ ges_base_xml_formatter_add_control_binding (GESBaseXmlFormatter * self,
         property_name, binding_type);
 
     g_object_set (source, "mode", mode, NULL);
-    gst_timed_value_control_source_set_from_list (GST_TIMED_VALUE_CONTROL_SOURCE
-        (source), timed_values);
+    if (!gst_timed_value_control_source_set_from_list
+        (GST_TIMED_VALUE_CONTROL_SOURCE (source), timed_values)) {
+      GST_ERROR_OBJECT (self, "Could not set timed values on %" GES_FORMAT,
+          GES_ARGS (source));
+    }
 
     gst_object_unref (source);
   } else