From: yangguo@chromium.org Date: Mon, 11 Nov 2013 15:28:47 +0000 (+0000) Subject: Fix potential assertion failure. X-Git-Tag: upstream/4.7.83~11802 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7fd7bbdcad625aab8d45d6ad035090e58c68ff4d;p=platform%2Fupstream%2Fv8.git Fix potential assertion failure. R=mvstanton@chromium.org BUG= Review URL: https://codereview.chromium.org/68913002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17621 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- diff --git a/src/factory.cc b/src/factory.cc index cccc3e7..da85b12 100644 --- a/src/factory.cc +++ b/src/factory.cc @@ -310,8 +310,7 @@ Handle ConcatStringContent(Handle result, Handle Factory::NewFlatConcatString(Handle first, Handle second) { int total_length = first->length() + second->length(); - if (first->IsOneByteRepresentationUnderneath() && - second->IsOneByteRepresentationUnderneath()) { + if (first->IsOneByteRepresentation() && second->IsOneByteRepresentation()) { return ConcatStringContent( NewRawOneByteString(total_length), first, second); } else { diff --git a/src/objects.cc b/src/objects.cc index 441c25e..e5b4763 100644 --- a/src/objects.cc +++ b/src/objects.cc @@ -8339,11 +8339,6 @@ SmartArrayPointer String::ToCString(AllowNullsFlag allow_nulls, } -const uc16* String::GetTwoByteData() { - return GetTwoByteData(0); -} - - const uc16* String::GetTwoByteData(unsigned start) { ASSERT(!IsOneByteRepresentationUnderneath()); switch (StringShape(this).representation_tag()) { diff --git a/src/objects.h b/src/objects.h index 3105579..0099cb2 100644 --- a/src/objects.h +++ b/src/objects.h @@ -8611,7 +8611,6 @@ class String: public Name { static const int kMaxShortPrintLength = 1024; // Support for regular expressions. - const uc16* GetTwoByteData(); const uc16* GetTwoByteData(unsigned start); // Helper function for flattening strings.