From: Dawid Juszczak <d.juszczak@samsung.com>
Date: Mon, 30 Sep 2019 14:01:35 +0000 (+0200)
Subject: [fix][mediacontroller] fix error with new metadata features
X-Git-Tag: submit/tizen/20190930.141103^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7fbaf96b5bedfed4df77c9b3eed6e21a2d5b4d2d;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git

[fix][mediacontroller] fix error with new metadata features

Change-Id: I957a41a84d1a8382c060ea615485c0c0f4d18602
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
---

diff --git a/src/mediacontroller/mediacontroller_utils.cc b/src/mediacontroller/mediacontroller_utils.cc
index 7c5507e1..2af70907 100644
--- a/src/mediacontroller/mediacontroller_utils.cc
+++ b/src/mediacontroller/mediacontroller_utils.cc
@@ -332,7 +332,7 @@ ErrorCode utils::ConvertMediaControllerError(int e) {
   return error;
 }
 
-bool isEncodable(std::string name) {
+bool utils::isEncodable(const std::string &name) {
   if (name == "season" || name == "episode" || name == "resolution") {
     return true;
   }
@@ -445,7 +445,8 @@ PlatformResult utils::DecodeMetadata(const picojson::value &to_decode, picojson:
   }
 
   (*decoded)["seasonNumber"] = picojson::value((double)number);
-  (*decoded)["episodeTitle"] = season_title ? picojson::value(std::string(season_title)) : picojson::value();
+  (*decoded)["episodeTitle"] =
+      season_title ? picojson::value(std::string(season_title)) : picojson::value();
 
   // decode episode
   val = to_decode.get("episode").get<std::string>();
@@ -458,7 +459,8 @@ PlatformResult utils::DecodeMetadata(const picojson::value &to_decode, picojson:
   }
 
   (*decoded)["episodeNumber"] = picojson::value((double)number);
-  (*decoded)["episodeTitle"] = episode_title ? picojson::value(std::string(episode_title)) : picojson::value();
+  (*decoded)["episodeTitle"] =
+      episode_title ? picojson::value(std::string(episode_title)) : picojson::value();
 
   // decode resolution
   val = to_decode.get("resolution").get<std::string>();
diff --git a/src/mediacontroller/mediacontroller_utils.h b/src/mediacontroller/mediacontroller_utils.h
index 3922c433..47926f48 100644
--- a/src/mediacontroller/mediacontroller_utils.h
+++ b/src/mediacontroller/mediacontroller_utils.h
@@ -59,7 +59,7 @@ extern const common::PlatformEnum<mc_display_rotation_e> MediaControllerDisplayR
 namespace utils {
 common::PlatformResult GetAllPlaylists(const std::string& app_id, picojson::array* playlists);
 common::ErrorCode ConvertMediaControllerError(int e);
-bool isEncodable(std::string name);
+bool isEncodable(const std::string& name);
 common::PlatformResult EncodeMetadata(const picojson::object& to_encode, picojson::object* encoded);
 common::PlatformResult DecodeMetadata(const picojson::value& to_decode, picojson::object* decoded);
 }  // namespace utils