From: Jarno Rajahalme <jarno@ovn.org>
Date: Fri, 24 Feb 2017 01:08:53 +0000 (-0800)
Subject: netfilter: nf_ct_expect: nf_ct_expect_related_report(): Return zero on success.
X-Git-Tag: v4.14-rc1~1394^2~1^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7fb668ac7b498f7e8ba2de373fe8a8648bd39a4c;p=platform%2Fkernel%2Flinux-rpi.git

netfilter: nf_ct_expect: nf_ct_expect_related_report(): Return zero on success.

Commit 4dee62b1b9b4 ("netfilter: nf_ct_expect: nf_ct_expect_insert()
returns void") inadvertently changed the successful return value of
nf_ct_expect_related_report() from 0 to 1, which caused openvswitch
conntrack integration fail in FTP test cases.

Fix this by always returning zero on the success code path.

Fixes: 4dee62b1b9b4 ("netfilter: nf_ct_expect: nf_ct_expect_insert() returns void")
Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
Acked-by: Joe Stringer <joe@ovn.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/net/netfilter/nf_conntrack_expect.c b/net/netfilter/nf_conntrack_expect.c
index e19a697..d6ace69 100644
--- a/net/netfilter/nf_conntrack_expect.c
+++ b/net/netfilter/nf_conntrack_expect.c
@@ -467,7 +467,7 @@ int nf_ct_expect_related_report(struct nf_conntrack_expect *expect,
 
 	spin_unlock_bh(&nf_conntrack_expect_lock);
 	nf_ct_expect_event_report(IPEXP_NEW, expect, portid, report);
-	return ret;
+	return 0;
 out:
 	spin_unlock_bh(&nf_conntrack_expect_lock);
 	return ret;