From: Eric W. Biederman <ebiederm@xmission.com>
Date: Mon, 22 Nov 2021 15:51:03 +0000 (-0600)
Subject: exit: Stop poorly open coding do_task_dead in make_task_dead
X-Git-Tag: v6.1-rc5~2203^2~37
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7f80a2fd7db9a55894fd841915236aca611291b5;p=platform%2Fkernel%2Flinux-starfive.git

exit: Stop poorly open coding do_task_dead in make_task_dead

When the kernel detects it is oops or otherwise force killing a task
while it exits the code poorly attempts to permanently stop the task
from scheduling.

I say poorly because it is possible for a task in TASK_UINTERRUPTIBLE
to be woken up.

As it makes no sense for the task to continue call do_task_dead
instead which actually does the work and permanently removes the task
from the scheduler.  Guaranteeing the task will never be woken
up again.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---

diff --git a/kernel/exit.c b/kernel/exit.c
index d0ec6f6..f975cd8 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -886,8 +886,7 @@ void __noreturn make_task_dead(int signr)
 	if (unlikely(tsk->flags & PF_EXITING)) {
 		pr_alert("Fixing recursive fault but reboot is needed!\n");
 		futex_exit_recursive(tsk);
-		set_current_state(TASK_UNINTERRUPTIBLE);
-		schedule();
+		do_task_dead();
 	}
 
 	do_exit(signr);