From: Rohit kumar <rohitkr@codeaurora.org>
Date: Thu, 1 Nov 2018 12:38:49 +0000 (+0530)
Subject: ASoC: core: Invoke pcm_new() for all DAI-link
X-Git-Tag: accepted/tizen/unified/20190330.030053~119
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7f1ca410af2ebad5b1c92fdc94b723574e6ccd3f;p=platform%2Fkernel%2Flinux-exynos.git

ASoC: core: Invoke pcm_new() for all DAI-link

Remove no_pcm check to invoke pcm_new() for backend dai-links
too. This fixes crash in hdmi codec driver during hdmi_codec_startup()
while accessing chmap_info struct. chmap_info struct memory is
allocated in pcm_new() of hdmi codec driver which is not invoked
in case of DPCM when hdmi codec driver is part of backend dai-link.

Below is the crash stack:

[   61.635493] Unable to handle kernel NULL pointer dereference at virtual address 00000018
..
[   61.666696]   CM = 0, WnR = 1
[   61.669778] user pgtable: 4k pages, 39-bit VAs, pgd = ffffffc0d6633000
[   61.676526] [0000000000000018] *pgd=0000000153fc8003, *pud=0000000153fc8003, *pmd=0000000000000000
[   61.685793] Internal error: Oops: 96000046 [#1] PREEMPT SMP
[   61.722955] CPU: 7 PID: 2238 Comm: aplay Not tainted 4.14.72 #21
..
[   61.740269] PC is at hdmi_codec_startup+0x124/0x164
[   61.745308] LR is at hdmi_codec_startup+0xe4/0x164

Change-Id: I1335d13ffb7f0fd1ba10884ff23b81b6b51a3889
Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
---

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 5b79a95..e1e4050 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1664,7 +1664,7 @@ static int soc_link_dai_pcm_new(struct snd_soc_dai **dais, int num_dais,
 	for (i = 0; i < num_dais; ++i) {
 		struct snd_soc_dai_driver *drv = dais[i]->driver;
 
-		if (!rtd->dai_link->no_pcm && drv->pcm_new)
+		if (drv->pcm_new)
 			ret = drv->pcm_new(rtd, dais[i]);
 		if (ret < 0) {
 			dev_err(dais[i]->dev,