From: Sebastian Dröge <sebastian@centricular.com>
Date: Tue, 2 Nov 2021 15:54:46 +0000 (+0200)
Subject: qtdemux: Don't free cslg data that we don't own on corrupt files
X-Git-Tag: 1.20.0~298
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7f105a919a73e49b8210a7e40de2a148129ae065;p=platform%2Fupstream%2Fgstreamer.git

qtdemux: Don't free cslg data that we don't own on corrupt files

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1294>
---

diff --git a/subprojects/gst-plugins-good/gst/isomp4/qtdemux.c b/subprojects/gst-plugins-good/gst/isomp4/qtdemux.c
index f823ff1..ae30290 100644
--- a/subprojects/gst-plugins-good/gst/isomp4/qtdemux.c
+++ b/subprojects/gst-plugins-good/gst/isomp4/qtdemux.c
@@ -9386,10 +9386,8 @@ qtdemux_stbl_init (GstQTDemux * qtdemux, QtDemuxStream * stream, GNode * stbl)
     /* This is optional, if missing we iterate the ctts */
     if (qtdemux_tree_get_child_by_type_full (stbl, FOURCC_cslg, &cslg)) {
       if (!gst_byte_reader_skip (&cslg, 1 + 3)
-          || !gst_byte_reader_get_uint32_be (&cslg, &stream->cslg_shift)) {
-        g_free ((gpointer) cslg.data);
+          || !gst_byte_reader_get_uint32_be (&cslg, &stream->cslg_shift))
         goto corrupt_file;
-      }
     } else {
       gint32 cslg_least = 0;
       guint num_entries, pos;