From: Colin Ian King Date: Wed, 24 Jun 2020 12:07:10 +0000 (+0100) Subject: drm/radeon: fix array out-of-bounds read and write issues X-Git-Tag: v5.10.7~1861^2~25^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7ee78aff9de13d5dccba133f4a0de5367194b243;p=platform%2Fkernel%2Flinux-rpi.git drm/radeon: fix array out-of-bounds read and write issues There is an off-by-one bounds check on the index into arrays table->mc_reg_address and table->mc_reg_table_entry[k].mc_data[j] that can lead to reads and writes outside of arrays. Fix the bound checking off-by-one error. Addresses-Coverity: ("Out-of-bounds read/write") Fixes: cc8dbbb4f62a ("drm/radeon: add dpm support for CI dGPUs (v2)") Signed-off-by: Colin Ian King Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dpm.c index 134aa2b..86ac032 100644 --- a/drivers/gpu/drm/radeon/ci_dpm.c +++ b/drivers/gpu/drm/radeon/ci_dpm.c @@ -4351,7 +4351,7 @@ static int ci_set_mc_special_registers(struct radeon_device *rdev, table->mc_reg_table_entry[k].mc_data[j] |= 0x100; } j++; - if (j > SMU7_DISCRETE_MC_REGISTER_ARRAY_SIZE) + if (j >= SMU7_DISCRETE_MC_REGISTER_ARRAY_SIZE) return -EINVAL; if (!pi->mem_gddr5) {