From: Jing Yao Date: Thu, 4 Nov 2021 11:47:54 +0000 (+0000) Subject: serial: 8250: replace snprintf in show functions with sysfs_emit X-Git-Tag: v6.6.17~8431^2~120 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7ee7482e60fd7a870ca7cd13f4c7bc3841f99815;p=platform%2Fkernel%2Flinux-rpi.git serial: 8250: replace snprintf in show functions with sysfs_emit coccicheck complains about the use of snprintf() in sysfs show functions: WARNING use scnprintf or sprintf Use sysfs_emit instead of scnprintf or sprintf makes more sense. Reported-by: Zeal Robot Reviewed-by: Johan Hovold Signed-off-by: Jing Yao Link: https://lore.kernel.org/r/20211104114754.30983-1-yao.jing2@zte.com.cn Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c index 5775cbf..3d58f38 100644 --- a/drivers/tty/serial/8250/8250_port.c +++ b/drivers/tty/serial/8250/8250_port.c @@ -3099,7 +3099,7 @@ static ssize_t rx_trig_bytes_show(struct device *dev, if (rxtrig_bytes < 0) return rxtrig_bytes; - return snprintf(buf, PAGE_SIZE, "%d\n", rxtrig_bytes); + return sysfs_emit(buf, "%d\n", rxtrig_bytes); } static int do_set_rxtrig(struct tty_port *port, unsigned char bytes)