From: Woochanlee Date: Tue, 7 Jul 2020 10:20:53 +0000 (+0100) Subject: edje: Avoid string duplication when possible. X-Git-Tag: submit/tizen/20200709.223535~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7ee0127569e17ed84cc42aeaec2091c6a682af77;p=platform%2Fupstream%2Fefl.git edje: Avoid string duplication when possible. Summary: Most use case the part name dosen't contain the recursive name so we don't have to go through expensive eina_string_split operation. Reviewers: smohanty, cedric, Hermet, raster Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D12045 --- diff --git a/src/lib/edje/edje_util.c b/src/lib/edje/edje_util.c index c1bbaf6..972bf40 100644 --- a/src/lib/edje/edje_util.c +++ b/src/lib/edje/edje_util.c @@ -5838,17 +5838,23 @@ _edje_real_part_text_text_source_description_get(Edje_Real_Part *ep, Edje_Real_P Edje_Real_Part * _edje_real_part_recursive_get(Edje **ed, const char *part) { - Edje_Real_Part *rp; - char **path; + if ((*ed)->collection && (*ed)->collection->alias) + { + Edje_Real_Part *rp; + char **path; - path = eina_str_split(part, EDJE_PART_PATH_SEPARATOR_STRING, 0); - if (!path) return NULL; + path = eina_str_split(part, EDJE_PART_PATH_SEPARATOR_STRING, 0); + if (!path) return NULL; - rp = _edje_real_part_recursive_get_helper(ed, path); + rp = _edje_real_part_recursive_get_helper(ed, path); + + free(*path); + free(path); + + return rp; + } - free(*path); - free(path); - return rp; + return _edje_real_part_get(*ed, part);; } Evas_Object *