From: Robert Yang Date: Mon, 17 Nov 2014 10:27:36 +0000 (-0800) Subject: bitbake: bitbake-worker: exit normally when SIGHUP X-Git-Tag: rev_ivi_2015_02_04~811 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7eb33cdb4d4f3daf7de3c018bbad9c39eccaa597;p=scm%2Fbb%2Ftizen-distro.git bitbake: bitbake-worker: exit normally when SIGHUP Fixed: 1) Run "bitbake recipe" in the terminal 2) Close the terminal while building 3) $ ps aux | grep bitbake-worker There will be many processes, and they will keep the resources (e.g., memory), and won't exit unless kill or kill -9. (Bitbake rev: 72536d4e0cc3379001b730950afa012f7a96a79b) Signed-off-by: Robert Yang Signed-off-by: Richard Purdie Signed-off-by: Patrick Ohly --- diff --git a/bitbake/bin/bitbake-worker b/bitbake/bin/bitbake-worker index dde2c9c..371c99a 100755 --- a/bitbake/bin/bitbake-worker +++ b/bitbake/bin/bitbake-worker @@ -147,6 +147,8 @@ def fork_off_task(cfg, data, workerdata, fn, task, taskname, appends, taskdepdat pipein.close() signal.signal(signal.SIGTERM, sigterm_handler) + # Let SIGHUP exit as SIGTERM + signal.signal(signal.SIGHUP, sigterm_handler) # Save out the PID so that the event can include it the # events @@ -266,9 +268,14 @@ class BitbakeWorker(object): self.build_pipes = {} signal.signal(signal.SIGTERM, self.sigterm_exception) + # Let SIGHUP exit as SIGTERM + signal.signal(signal.SIGHUP, self.sigterm_exception) def sigterm_exception(self, signum, stackframe): - bb.warn("Worker recieved SIGTERM, shutting down...") + if signum == signal.SIGTERM: + bb.warn("Worker recieved SIGTERM, shutting down...") + elif signum == signal.SIGHUP: + bb.warn("Worker recieved SIGHUP, shutting down...") self.handle_finishnow(None) signal.signal(signal.SIGTERM, signal.SIG_DFL) os.kill(os.getpid(), signal.SIGTERM) diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py index c6c69c3..a900b07 100644 --- a/bitbake/lib/bb/cooker.py +++ b/bitbake/lib/bb/cooker.py @@ -153,9 +153,14 @@ class BBCooker: self.parser = None signal.signal(signal.SIGTERM, self.sigterm_exception) + # Let SIGHUP exit as SIGTERM + signal.signal(signal.SIGHUP, self.sigterm_exception) def sigterm_exception(self, signum, stackframe): - bb.warn("Cooker recieved SIGTERM, shutting down...") + if signum == signal.SIGTERM: + bb.warn("Cooker recieved SIGTERM, shutting down...") + elif signum == signal.SIGHUP: + bb.warn("Cooker recieved SIGHUP, shutting down...") self.state = state.forceshutdown def setFeatures(self, features):