From: Vaibhav Gupta Date: Mon, 2 Nov 2020 16:47:24 +0000 (+0530) Subject: scsi: 3w-sas: Drop PCI Wakeup calls from .resume X-Git-Tag: accepted/tizen/unified/20230118.172025~8143^2~105 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7ea03ab79e00fccd2a12c1526fb3c7703c8a7baa;p=platform%2Fkernel%2Flinux-rpi.git scsi: 3w-sas: Drop PCI Wakeup calls from .resume The driver calls pci_enable_wake(...., false) in twl_resume(), and there is no corresponding pci_enable_wake(...., true) in twl_suspend(). Either it should do enable-wake the device in .suspend() or should not invoke pci_enable_wake() at all. Concluding that this driver doesn't support enable-wake and PCI core calls pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from twl_resume(). Link: https://lore.kernel.org/r/20201102164730.324035-24-vaibhavgupta40@gmail.com Signed-off-by: Vaibhav Gupta Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/3w-sas.c b/drivers/scsi/3w-sas.c index dda6fa8..0b48881 100644 --- a/drivers/scsi/3w-sas.c +++ b/drivers/scsi/3w-sas.c @@ -1795,7 +1795,6 @@ static int twl_resume(struct pci_dev *pdev) printk(KERN_WARNING "3w-sas: Resuming host %d.\n", tw_dev->host->host_no); pci_set_power_state(pdev, PCI_D0); - pci_enable_wake(pdev, PCI_D0, 0); pci_restore_state(pdev); retval = pci_enable_device(pdev);