From: David Henningsson Date: Fri, 4 Mar 2011 13:22:25 +0000 (+0100) Subject: ALSA: HDA: Fixup unnecessary volume control index on Realtek ALC88x X-Git-Tag: accepted/tizen/common/20141203.182822~7926^2~24^2~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7e59e097c09b82760bb0fe08b0fa2b704d76c3f4;p=platform%2Fkernel%2Flinux-arm64.git ALSA: HDA: Fixup unnecessary volume control index on Realtek ALC88x Without this change, a volume control named "Surround" or "Side" would get an unnecessary index, causing it to be ignored by the vmaster and PulseAudio. Tested-by: Bartłomiej Żogała Cc: Signed-off-by: David Henningsson Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 6f59bcc..24bbc47 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5136,16 +5136,19 @@ static int alc880_auto_create_multi_out_ctls(struct alc_spec *spec, return err; } else { const char *name = pfx; - if (!name) + int index = i; + if (!name) { name = chname[i]; + index = 0; + } err = __add_pb_vol_ctrl(spec, ALC_CTL_WIDGET_VOL, - name, i, + name, index, HDA_COMPOSE_AMP_VAL(nid, 3, 0, HDA_OUTPUT)); if (err < 0) return err; err = __add_pb_sw_ctrl(spec, ALC_CTL_BIND_MUTE, - name, i, + name, index, HDA_COMPOSE_AMP_VAL(nid, 3, 2, HDA_INPUT)); if (err < 0)