From: Youngjae Shin Date: Mon, 21 Oct 2019 07:52:39 +0000 (+0900) Subject: revise parameter name for readability X-Git-Tag: submit/tizen/20200319.043412~46 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7e4fafe52bd4c896f4c96e35661d6f6f751aa16f;p=platform%2Fcore%2Fsystem%2Fmodes.git revise parameter name for readability --- diff --git a/include/Plugin.h b/include/Plugin.h index 4d98c83..d120ccd 100644 --- a/include/Plugin.h +++ b/include/Plugin.h @@ -42,28 +42,28 @@ namespace ModeSupervisorNamespace { return name; } - virtual int set(const std::string &key, int val, PluginAction **pluginAction) + virtual int set(const std::string &key, int val, PluginAction **piAction) { return MODES_ERROR_NOT_SUPPORTED; } - virtual int set(const std::string &key, double val, PluginAction **pluginAction) + virtual int set(const std::string &key, double val, PluginAction **piAction) { return MODES_ERROR_NOT_SUPPORTED; } - virtual int set(const std::string &key, bool val, PluginAction **pluginAction) + virtual int set(const std::string &key, bool val, PluginAction **piAction) { return MODES_ERROR_NOT_SUPPORTED; } - virtual int set(const std::string &key, const std::string &val, PluginAction **pluginAction) + virtual int set(const std::string &key, const std::string &val, PluginAction **piAction) { return MODES_ERROR_NOT_SUPPORTED; } - virtual int undo(PluginAction *pluginAction) + virtual int undo(PluginAction *piAction) { - if (NULL == pluginAction) + if (NULL == piAction) return MODES_ERROR_INVALID_PARAMETER; - int ret = pluginAction->undo(); - delete pluginAction; + int ret = piAction->undo(); + delete piAction; return ret; } @@ -71,13 +71,13 @@ namespace ModeSupervisorNamespace { { return nullptr; } - virtual int serializeAction(PluginAction *pluginAction, std::string *output) + virtual int serializeAction(PluginAction *piAction, std::string *output) { return MODES_ERROR_NOT_SUPPORTED; } - void freeAction(PluginAction *pluginAction) + void freeAction(PluginAction *piAction) { - delete pluginAction; + delete piAction; } virtual int getInt(const std::string &key) { diff --git a/plugin/TestPlugin.cpp b/plugin/TestPlugin.cpp index ab22bcd..e944731 100644 --- a/plugin/TestPlugin.cpp +++ b/plugin/TestPlugin.cpp @@ -29,14 +29,14 @@ public: TestPlugin(); ~TestPlugin(); - int set(const std::string &key, int val, PluginAction **pluginAction) override; - int set(const std::string &key, double val, PluginAction **pluginAction) override; - int set(const std::string &key, bool val, PluginAction **pluginAction) override; - int set(const std::string &key, const std::string &val, PluginAction **pluginAction) override; + int set(const std::string &key, int val, PluginAction **piAction) override; + int set(const std::string &key, double val, PluginAction **piAction) override; + int set(const std::string &key, bool val, PluginAction **piAction) override; + int set(const std::string &key, const std::string &val, PluginAction **piAction) override; - int undo(PluginAction *pluginAction) override; + int undo(PluginAction *piAction) override; PluginAction* getUndoAction(const std::string &key, const std::string &info) override; - int serializeAction(PluginAction *pluginAction, std::string *output) override; + int serializeAction(PluginAction *piAction, std::string *output) override; int getInt(const std::string &key) override; double getDouble(const std::string &key) override; @@ -67,56 +67,56 @@ TestPlugin::~TestPlugin() { } -int TestPlugin::set(const std::string &key, int val, PluginAction **pluginAction) +int TestPlugin::set(const std::string &key, int val, PluginAction **piAction) { DBG("TestPlugin::set int ( %s, %d )", key.c_str(), val); - if (pluginAction) { + if (piAction) { TestPluginAction *testAction = new TestPluginAction(); - *pluginAction = testAction; + *piAction = testAction; } return MODES_ERROR_NONE; } -int TestPlugin::set(const std::string &key, double val, PluginAction **pluginAction) +int TestPlugin::set(const std::string &key, double val, PluginAction **piAction) { DBG("TestPlugin::set double ( %s, %lf )", key.c_str(), val); - if (pluginAction) { + if (piAction) { TestPluginAction *testAction = new TestPluginAction(); - *pluginAction = testAction; + *piAction = testAction; } return MODES_ERROR_NONE; } -int TestPlugin::set(const std::string &key, bool val, PluginAction **pluginAction) +int TestPlugin::set(const std::string &key, bool val, PluginAction **piAction) { DBG("TestPlugin::set bool ( %s, %s )", key.c_str(), val ? "true" : "false"); - if (pluginAction) { + if (piAction) { TestPluginAction *testAction = new TestPluginAction(); - *pluginAction = testAction; + *piAction = testAction; } return MODES_ERROR_NONE; } -int TestPlugin::set(const std::string &key, const std::string &val, PluginAction **pluginAction) +int TestPlugin::set(const std::string &key, const std::string &val, PluginAction **piAction) { DBG("TestPlugin::set string ( %s, %s )", key.c_str(), val.c_str()); - if (pluginAction) { + if (piAction) { TestPluginAction *testAction = new TestPluginAction(); - *pluginAction = testAction; + *piAction = testAction; } return MODES_ERROR_NONE; } -int TestPlugin::undo(PluginAction *pluginAction) +int TestPlugin::undo(PluginAction *piAction) { - if (pluginAction) { - DBG("TestPlugin::undo(Action:%s)", pluginAction->getName().c_str()); + if (piAction) { + DBG("TestPlugin::undo(Action:%s)", piAction->getName().c_str()); - delete pluginAction; + delete piAction; } return MODES_ERROR_NONE;