From: Vineeth T M <vineeth.tm@samsung.com>
Date: Wed, 22 Apr 2015 09:54:45 +0000 (+0900)
Subject: glmixer: Possible null pointer dereference
X-Git-Tag: 1.19.3~507^2~8935
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7e3cd63f870fc3be92553f25ca685413e8fc20c3;p=platform%2Fupstream%2Fgstreamer.git

glmixer: Possible null pointer dereference

While printing error message when context fails, error variable is not being used anymore
so it will lead to null pointer dereference

https://bugzilla.gnome.org/show_bug.cgi?id=748287
---

diff --git a/ext/gl/gstglmixer.c b/ext/gl/gstglmixer.c
index 96d6e2a..8e35af1 100644
--- a/ext/gl/gstglmixer.c
+++ b/ext/gl/gstglmixer.c
@@ -502,7 +502,6 @@ gst_gl_mixer_decide_allocation (GstGLBaseMixer * base_mix, GstQuery * query)
   GstCaps *caps;
   guint min, max, size;
   gboolean update_pool;
-  GError *error = NULL;
   guint out_width, out_height;
 
   out_width = GST_VIDEO_INFO_WIDTH (&vagg->info);
@@ -566,8 +565,7 @@ gst_gl_mixer_decide_allocation (GstGLBaseMixer * base_mix, GstQuery * query)
 
 context_error:
   {
-    GST_ELEMENT_ERROR (mix, RESOURCE, NOT_FOUND, ("%s", error->message),
-        (NULL));
+    GST_ELEMENT_ERROR (mix, RESOURCE, NOT_FOUND, ("Context error"), (NULL));
     return FALSE;
   }
 }