From: Wei Yongjun Date: Sat, 18 Jun 2016 17:26:07 +0000 (+0000) Subject: mfd: hi655x: Fix return value check in hi655x_pmic_probe() X-Git-Tag: v4.14-rc1~2754^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7e28abda8c1f08e8926ed1b9fbfb6efdfc88c19b;p=platform%2Fkernel%2Flinux-rpi.git mfd: hi655x: Fix return value check in hi655x_pmic_probe() In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Also remove unneeded error handling of platform_get_resource(). Signed-off-by: Wei Yongjun Signed-off-by: Lee Jones --- diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c index e955a0c..0fc6299 100644 --- a/drivers/mfd/hi655x-pmic.c +++ b/drivers/mfd/hi655x-pmic.c @@ -105,12 +105,9 @@ static int hi655x_pmic_probe(struct platform_device *pdev) pmic->dev = dev; pmic->res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!pmic->res) - return -ENOENT; - base = devm_ioremap_resource(dev, pmic->res); - if (!base) - return -ENOMEM; + if (IS_ERR(base)) + return PTR_ERR(base); pmic->regmap = devm_regmap_init_mmio_clk(dev, NULL, base, &hi655x_regmap_config);