From: Louis Dionne Date: Fri, 21 Feb 2020 18:53:50 +0000 (-0500) Subject: [libc++] Do not set the `availability=XXX` feature when not testing against a system... X-Git-Tag: llvmorg-12-init~13958 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7dd6a862e5ece866c787d4509a5a5cad19531fbc;p=platform%2Fupstream%2Fllvm.git [libc++] Do not set the `availability=XXX` feature when not testing against a system libc++ Otherwise, the `availability=XXX` lit feature is set even when we're testing trunk and _LIBCPP_DISABLE_AVAILABILITY is defined, which causes tests that check for availability markup to be enabled and unexpectedly pass. --- diff --git a/libcxx/utils/libcxx/test/config.py b/libcxx/utils/libcxx/test/config.py index 215faf2..8d6b901 100644 --- a/libcxx/utils/libcxx/test/config.py +++ b/libcxx/utils/libcxx/test/config.py @@ -418,7 +418,7 @@ class Configuration(object): # Configure the availability feature. Availability is only enabled # with libc++, because other standard libraries do not provide # availability markup. - if self.use_deployment and self.cxx_stdlib_under_test == 'libc++': + if self.use_deployment and self.cxx_stdlib_under_test == 'libc++' and self.use_system_cxx_lib: self.config.available_features.add('availability') self.add_deployment_feature('availability')