From: Vaibhav Gupta Date: Mon, 2 Nov 2020 16:47:05 +0000 (+0530) Subject: scsi: aacraid: Drop pci_enable_wake() from .resume X-Git-Tag: v5.15~2044^2~124 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7dd2222180762656ccaf9e42ecc289f59fd43bc4;p=platform%2Fkernel%2Flinux-starfive.git scsi: aacraid: Drop pci_enable_wake() from .resume The driver calls pci_enable_wake(...., false) in aac_resume(), and there is no corresponding pci_enable_wake(...., true) in aac_suspend(). Either it should do enable-wake the device in .suspend() or should not invoke pci_enable_wake() at all. Concluding that this is a bug and PCI core calls pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from aac_resume(). Link: https://lore.kernel.org/r/20201102164730.324035-5-vaibhavgupta40@gmail.com Signed-off-by: Vaibhav Gupta Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index 0a82afa..114690b 100644 --- a/drivers/scsi/aacraid/linit.c +++ b/drivers/scsi/aacraid/linit.c @@ -1881,7 +1881,6 @@ static int aac_resume(struct pci_dev *pdev) int r; pci_set_power_state(pdev, PCI_D0); - pci_enable_wake(pdev, PCI_D0, 0); pci_restore_state(pdev); r = pci_enable_device(pdev);