From: Herbert Xu Date: Fri, 6 Dec 2019 05:55:17 +0000 (+0800) Subject: crypto: api - Check spawn->alg under lock in crypto_drop_spawn X-Git-Tag: v5.10.7~3034^2~161 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7db3b61b6bba4310f454588c2ca6faf2958ad79f;p=platform%2Fkernel%2Flinux-rpi.git crypto: api - Check spawn->alg under lock in crypto_drop_spawn We need to check whether spawn->alg is NULL under lock as otherwise the algorithm could be removed from under us after we have checked it and found it to be non-NULL. This could cause us to remove the spawn from a non-existent list. Fixes: 7ede5a5ba55a ("crypto: api - Fix crypto_drop_spawn crash...") Cc: Signed-off-by: Herbert Xu --- diff --git a/crypto/algapi.c b/crypto/algapi.c index b052f38..9ecb4a5 100644 --- a/crypto/algapi.c +++ b/crypto/algapi.c @@ -669,11 +669,9 @@ EXPORT_SYMBOL_GPL(crypto_grab_spawn); void crypto_drop_spawn(struct crypto_spawn *spawn) { - if (!spawn->alg) - return; - down_write(&crypto_alg_sem); - list_del(&spawn->list); + if (spawn->alg) + list_del(&spawn->list); up_write(&crypto_alg_sem); } EXPORT_SYMBOL_GPL(crypto_drop_spawn);