From: NeilBrown <neilb@suse.de>
Date: Tue, 30 Aug 2011 06:20:17 +0000 (+1000)
Subject: md: fix clearing of 'blocked' flag in the presence of bad blocks.
X-Git-Tag: v3.12-rc1~4585^2~41
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7da64a0abc3b2c6cbd3521672e9bb74dd560bb89;p=kernel%2Fkernel-generic.git

md: fix clearing of 'blocked' flag in the presence of bad blocks.

When the 'blocked' flag on a device is cleared while there are
unacknowledged bad blocks we must fail the device.  This is needed for
backwards compatability of the interface.

The code currently uses the wrong test for "unacknowledged bad blocks
exist".  Change it to the right test.

Signed-off-by: NeilBrown <neilb@suse.de>
---

diff --git a/drivers/md/md.c b/drivers/md/md.c
index aca6117..3742ce8 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -2592,7 +2592,7 @@ state_store(mdk_rdev_t *rdev, const char *buf, size_t len)
 		err = 0;
 	} else if (cmd_match(buf, "-blocked")) {
 		if (!test_bit(Faulty, &rdev->flags) &&
-		    test_bit(BlockedBadBlocks, &rdev->flags)) {
+		    rdev->badblocks.unacked_exist) {
 			/* metadata handler doesn't understand badblocks,
 			 * so we need to fail the device
 			 */