From: Armin Wolf Date: Tue, 15 Feb 2022 19:11:13 +0000 (+0100) Subject: hwmon: (dell-smm) Reword and mark parameter "force" as unsafe X-Git-Tag: v6.6.17~7988^2~26 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7cd682b027ee1ed8bcf1e79e208c2b6b1a4d31b7;p=platform%2Fkernel%2Flinux-rpi.git hwmon: (dell-smm) Reword and mark parameter "force" as unsafe When enabling said module parameter, the driver ignores all feature blacklists on relevant models, which has the potential for strange side effects. Also there seems to be a slight chance for unsupported devices to behave badly when probed for features. In such cases, the kernel should be tainted to inform people that these issues might have been caused by the dell_smm_hwmon driver with "force" enabled. Also reword the parameter description to remind users that enabling "force" also enables blacklisted features. Tested on a Dell Inspiron 3505. Signed-off-by: Armin Wolf Reviewed-by: Pali Rohár Link: https://lore.kernel.org/r/20220215191113.16640-8-W_Armin@gmx.de Signed-off-by: Guenter Roeck --- diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index 9949eeb..1fd6726 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -86,8 +86,8 @@ MODULE_LICENSE("GPL"); MODULE_ALIAS("i8k"); static bool force; -module_param(force, bool, 0); -MODULE_PARM_DESC(force, "Force loading without checking for supported models"); +module_param_unsafe(force, bool, 0); +MODULE_PARM_DESC(force, "Force loading without checking for supported models and features"); static bool ignore_dmi; module_param(ignore_dmi, bool, 0);