From: Bhaktipriya Shridhar Date: Thu, 18 Feb 2016 18:54:30 +0000 (+0530) Subject: staging: rtl8712: Replace explicit NULL comparison X-Git-Tag: v4.6-rc1~103^2~632 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7cb07dc4e4431546979242f86f4cf5af233bb860;p=platform%2Fkernel%2Flinux-exynos.git staging: rtl8712: Replace explicit NULL comparison Replace explicit NULL comparison with ! operator. Found with Coccinelle. @@ expression e; @@ - e == NULL + !e Signed-off-by: Bhaktipriya Shridhar Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c index d398183..f8866d7 100644 --- a/drivers/staging/rtl8712/xmit_linux.c +++ b/drivers/staging/rtl8712/xmit_linux.c @@ -131,7 +131,7 @@ int r8712_xmit_resource_alloc(struct _adapter *padapter, for (i = 0; i < 8; i++) { pxmitbuf->pxmit_urb[i] = usb_alloc_urb(0, GFP_KERNEL); - if (pxmitbuf->pxmit_urb[i] == NULL) { + if (!pxmitbuf->pxmit_urb[i]) { netdev_err(padapter->pnetdev, "pxmitbuf->pxmit_urb[i] == NULL\n"); return _FAIL; } @@ -171,7 +171,7 @@ int r8712_xmit_entry(_pkt *pkt, struct net_device *pnetdev) goto _xmit_entry_drop; } pxmitframe = r8712_alloc_xmitframe(pxmitpriv); - if (pxmitframe == NULL) { + if (!pxmitframe) { ret = 0; goto _xmit_entry_drop; }