From: Zach Brown <zab@redhat.com>
Date: Tue, 22 Jan 2013 21:48:04 +0000 (-0800)
Subject: btrfs-progs: check for open failure, don't close
X-Git-Tag: upstream/4.16.1~3459^2~27
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7c9f323a7c9c7a0d7b516ed9974308bde4017ae2;p=platform%2Fupstream%2Fbtrfs-progs.git

btrfs-progs: check for open failure, don't close

Check for failure by testing for a negative file descriptor, not a
descriptor of 0.  And if it failed we have nothing to close().

Signed-off-by: Zach Brown <zab@redhat.com>
---

diff --git a/cmds-device.c b/cmds-device.c
index d4938f4..7a0f7a4 100644
--- a/cmds-device.c
+++ b/cmds-device.c
@@ -87,9 +87,8 @@ static int cmd_add_dev(int argc, char **argv)
 		}
 
 		devfd = open(argv[i], O_RDWR);
-		if (!devfd) {
+		if (devfd < 0) {
 			fprintf(stderr, "ERROR: Unable to open device '%s'\n", argv[i]);
-			close(devfd);
 			ret++;
 			continue;
 		}