From: SeokYeon Hwang <syeon.hwang@samsung.com>
Date: Wed, 16 Jul 2014 12:43:03 +0000 (+0900)
Subject: display: fix compilation error when SDL and SHM are both disabled
X-Git-Tag: Tizen_Studio_1.3_Release_p2.3.1~228^2^2~60^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7c877e7007f6078b52b7ff9a98f5d50acc5b2955;p=sdk%2Femulator%2Fqemu.git

display: fix compilation error when SDL and SHM are both disabled

Change-Id: Ie49c216469197a53383ef1f5403934c252122272
Signed-off-by: SeokYeon Hwang <syeon.hwang@samsung.com>
---

diff --git a/hw/vigs/Makefile.objs b/hw/vigs/Makefile.objs
index 92bb3df012..967bf46e7b 100644
--- a/hw/vigs/Makefile.objs
+++ b/hw/vigs/Makefile.objs
@@ -3,6 +3,7 @@ QEMU_CFLAGS += -I$(SRC_PATH)/hw/vigs/vigs_inc
 
 obj-y += vigs_log.o
 obj-y += vigs_device.o
+libs_softmmu += $(GLX_LIBS)
 obj-y += vigs_comm.o
 obj-y += vigs_server.o
 obj-y += vigs_backend.o
diff --git a/include/ui/console.h b/include/ui/console.h
index 9d2c5d9100..a95944f4af 100644
--- a/include/ui/console.h
+++ b/include/ui/console.h
@@ -9,7 +9,7 @@
 #include "qapi-types.h"
 #include "qapi/error.h"
 
-#if defined(CONFIG_MARU) && !defined(CONFIG_USE_SHM)
+#if defined(CONFIG_MARU) && defined(CONFIG_SDL)
 #define SDL_THREAD
 #endif
 
diff --git a/tizen/src/Makefile b/tizen/src/Makefile
index 961d70240f..f0a4cd57a6 100644
--- a/tizen/src/Makefile
+++ b/tizen/src/Makefile
@@ -53,12 +53,13 @@ ifdef CONFIG_DARWIN
 endif
 
 skin_client:
-#	TIZEN_SDK_DEV_PATH=${TIZEN_SDK_DEV_PATH} ant -buildfile skin/client/build.xml make-jar
 ifdef CONFIG_USE_SHM
 	TIZEN_SDK_DEV_PATH=${TIZEN_SDK_DEV_PATH} ant -DdoNotUseSHM=false -buildfile skin/client/build.xml make-jar
 else
+ifdef CONFIG_SDL
 	TIZEN_SDK_DEV_PATH=${TIZEN_SDK_DEV_PATH} ant -DdoNotUseSHM=true -buildfile skin/client/build.xml make-jar
 endif
+endif
 
 build_info:
 	@echo "Generate a build information file"
@@ -113,10 +114,15 @@ else
 endif
 
 # resources and jar for skin
+ifdef CONFIG_SDL
 	cp -pP skin/client/emulator-skin.jar $(EMUL_DIR)/bin
 	cp -pPR skin/client/skins $(EMUL_DIR)
-ifndef CONFIG_USE_SHM
 	cp -pP skin/client/resource/images/blank-guide.png $(EMUL_DIR)/images
+else
+ifdef CONFIG_USE_SHM
+	cp -pP skin/client/emulator-skin.jar $(EMUL_DIR)/bin
+	cp -pPR skin/client/skins $(EMUL_DIR)
+endif
 endif
 
 # check capabilities of OpenGL and Webcam
@@ -187,12 +193,13 @@ endif
 # for dibs system...
 all_dibs: qemu skin_client_dibs
 skin_client_dibs:
-#	ant -buildfile skin/client/build.xml -Dclasspath.dibs=$(ROOTDIR)/tools/emulator/bin make-jar-dibs
 ifdef CONFIG_USE_SHM
 	TIZEN_SDK_DEV_PATH=${TIZEN_SDK_DEV_PATH} ant -DdoNotUseSHM=false ${DIBS_SWT_DIR} -buildfile skin/client/build.xml make-jar
 else
+ifdef CONFIG_SDL
 	TIZEN_SDK_DEV_PATH=${TIZEN_SDK_DEV_PATH} ant -DdoNotNotUseSHM=true ${DIBS_SWT_DIR} -buildfile skin/client/build.xml make-jar
 endif
+endif
 
 
 install_dibs: all_dibs
@@ -231,10 +238,13 @@ else
 endif
 
 # resources and jar for skin
+ifdef CONFIG_SDL
 	cp -pP skin/client/emulator-skin.jar $(DIBS_COMMON_DIR)/bin
-	#cp -pPR skin/client/skins $(DIBS_COMMON_DIR)
-ifndef CONFIG_USE_SHM
 	cp -pP skin/client/resource/images/blank-guide.png $(DIBS_COMMON_DIR)/images
+else
+ifdef CONFIG_USE_SHM
+	cp -pP skin/client/emulator-skin.jar $(DIBS_COMMON_DIR)/bin
+endif
 endif
 
 # check capabilities of OpenGL and Webcam
diff --git a/tizen/src/display/Makefile.objs b/tizen/src/display/Makefile.objs
index 22e7499004..3660db9ee4 100644
--- a/tizen/src/display/Makefile.objs
+++ b/tizen/src/display/Makefile.objs
@@ -2,7 +2,9 @@ obj-y += maru_display.o
 ifdef CONFIG_USE_SHM
 obj-y += maru_shm.o
 else
+ifdef CONFIG_SDL
 obj-y += maru_sdl.o maru_sdl_processing.o maru_finger.o
 endif
+endif
 
 $(obj)/maru_display.o $(obj)/maru_sdl.o $(obj)/maru_sdl_processing.o $(obj)/maru_finger.o: QEMU_CFLAGS += $(SDL_CFLAGS)
diff --git a/tizen/src/display/maru_display.c b/tizen/src/display/maru_display.c
index 6276067d8e..23dff8f4b6 100644
--- a/tizen/src/display/maru_display.c
+++ b/tizen/src/display/maru_display.c
@@ -34,7 +34,9 @@
 #include "debug_ch.h"
 
 #ifndef CONFIG_USE_SHM
+#ifdef CONFIG_SDL
 #include "maru_sdl.h"
+#endif
 #else
 #include "maru_shm.h"
 #endif
@@ -50,7 +52,9 @@ static void maru_display_fini(void)
     g_free(screenshot);
 
 #ifndef CONFIG_USE_SHM
+#ifdef CONFIG_SDL
     maru_sdl_quit();
+#endif
 #else
     maru_shm_quit();
 #endif
@@ -67,7 +71,9 @@ void maru_display_init(DisplayState *ds)
     INFO("init qemu display\n");
 
 #ifndef CONFIG_USE_SHM
+#ifdef CONFIG_SDL
     maru_sdl_pre_init();
+#endif
 #else
     /* do nothing */
 #endif
@@ -76,7 +82,10 @@ void maru_display_init(DisplayState *ds)
     DisplayChangeListener *dcl;
 
     dcl = g_malloc0(sizeof(DisplayChangeListener));
+#if defined(CONFIG_USE_SHM) || defined(CONFIG_SDL)
+    //FIXME
     dcl->ops = &maru_dcl_ops;
+#endif
     register_displaychangelistener(dcl);
 
     screenshot = g_malloc0(sizeof(MaruScreenShot));
@@ -90,7 +99,9 @@ void maru_display_init(DisplayState *ds)
 void maru_display_resize(void)
 {
 #ifndef CONFIG_USE_SHM
+#ifdef CONFIG_SDL
     maru_sdl_resize();
+#endif
 #else
     maru_shm_resize();
 #endif
@@ -99,7 +110,9 @@ void maru_display_resize(void)
 void maru_display_update(void)
 {
 #ifndef CONFIG_USE_SHM
+#ifdef CONFIG_SDL
     maru_sdl_update();
+#endif
 #else
     /* do nothing */
 #endif
@@ -108,7 +121,9 @@ void maru_display_update(void)
 void maru_display_invalidate(bool on)
 {
 #ifndef CONFIG_USE_SHM
+#ifdef CONFIG_SDL
     maru_sdl_invalidate(on);
+#endif
 #else
     /* do nothing */
 #endif
@@ -117,7 +132,9 @@ void maru_display_invalidate(bool on)
 void maru_display_interpolation(bool on)
 {
 #ifndef CONFIG_USE_SHM
+#ifdef CONFIG_SDL
     maru_sdl_interpolation(on);
+#endif
 #else
     /* do nothing */
 #endif
@@ -128,8 +145,10 @@ void maru_ds_surface_init(uint64 swt_handle,
     bool blank_guide)
 {
 #ifndef CONFIG_USE_SHM
+#ifdef CONFIG_SDL
     maru_sdl_init(swt_handle,
         display_width, display_height, blank_guide);
+#endif
 #else
     maru_shm_init(swt_handle,
         display_width, display_height, blank_guide);
diff --git a/tizen/src/display/maru_finger.h b/tizen/src/display/maru_finger.h
index 61a32e854b..d5f071e326 100644
--- a/tizen/src/display/maru_finger.h
+++ b/tizen/src/display/maru_finger.h
@@ -31,8 +31,8 @@
 #ifndef __MARU_FINGER_H__
 #define __MARU_FINGER_H__
 
-#include "qemu-common.h"
-
+#include <stdint.h>
+#include <stdbool.h>
 
 /* definitions relating to multi-touch */
 #define MAX_FINGER_CNT 10
diff --git a/tizen/src/display/maru_sdl.c b/tizen/src/display/maru_sdl.c
index 1c92fe7412..cdc099de54 100644
--- a/tizen/src/display/maru_sdl.c
+++ b/tizen/src/display/maru_sdl.c
@@ -39,6 +39,7 @@
 #include "hw/pci/maru_brightness.h"
 #include "debug_ch.h"
 
+#include <SDL.h>
 #ifndef CONFIG_WIN32
 #include <SDL_syswm.h>
 #endif
diff --git a/tizen/src/display/maru_sdl.h b/tizen/src/display/maru_sdl.h
index 7b30156b60..87e4ec877d 100644
--- a/tizen/src/display/maru_sdl.h
+++ b/tizen/src/display/maru_sdl.h
@@ -32,7 +32,6 @@
 #ifndef MARU_SDL_H_
 #define MARU_SDL_H_
 
-#include <SDL.h>
 #include "ui/console.h"
 
 extern DisplayChangeListenerOps maru_dcl_ops;
diff --git a/tizen/src/ecs/ecs_msg.c b/tizen/src/ecs/ecs_msg.c
index 48f2f7f94f..0ac6538615 100644
--- a/tizen/src/ecs/ecs_msg.c
+++ b/tizen/src/ecs/ecs_msg.c
@@ -523,7 +523,7 @@ bool msgproc_device_req(ECS_Client* ccli, ECS__DeviceReq* msg)
         }
     } else if (!strncmp(cmd, "TGesture", strlen("TGesture"))) {
         /* release multi-touch */
-#ifndef CONFIG_USE_SHM
+#if !defined(CONFIG_USE_SHM) && defined(CONFIG_SDL)
         if (get_multi_touch_enable() != 0) {
             clear_finger_slot(false);
         }
diff --git a/tizen/src/emul_state.h b/tizen/src/emul_state.h
index 0cadfcd9ad..464becd5cb 100644
--- a/tizen/src/emul_state.h
+++ b/tizen/src/emul_state.h
@@ -107,9 +107,9 @@ typedef struct EmulatorConfigState {
 } EmulatorConfigState;
 
 /* misc */
-extern gchar bin_path[];
+extern char bin_path[];
 #ifdef SUPPORT_LEGACY_ARGS
-extern gchar log_path[];
+extern char log_path[];
 #endif
 
 char const *get_bin_path(void);
diff --git a/tizen/src/emulator.c b/tizen/src/emulator.c
index 60b1a5b5e1..572499f5f7 100644
--- a/tizen/src/emulator.c
+++ b/tizen/src/emulator.c
@@ -79,6 +79,7 @@ void emulator_add_exit_notifier(Notifier *notify)
     qemu_add_exit_notifier(notify);
 }
 
+#ifdef CONFIG_SDL
 static void construct_main_window(int skin_argc, char *skin_argv[],
                                 int qemu_argc, char *qemu_argv[])
 {
@@ -97,6 +98,7 @@ static void construct_main_window(int skin_argc, char *skin_argv[],
         }
     }
 }
+#endif
 
 static void get_host_proxy(char *http_proxy, char *https_proxy, char *ftp_proxy, char *socks_proxy)
 {
@@ -274,12 +276,14 @@ const char *prepare_maru(const gchar * const kernel_cmdline)
     return maru_kernel_cmdline;
 }
 
+#ifdef CONFIG_SDL
 void start_skin(void)
 {
     LOG_INFO("Start skin\n");
 
     construct_main_window(_skin_argc, _skin_argv, _qemu_argc, _qemu_argv);
 }
+#endif
 
 int qemu_main(int argc, char **argv, char **envp);
 int legacy_emulator_main(int argc, char **argv, char **envp);
@@ -448,4 +452,3 @@ int main(int argc, char *argv[])
     return emulator_main(argc, argv, NULL);
 }
 #endif
-
diff --git a/tizen/src/emulator_common.h b/tizen/src/emulator_common.h
index 64d221baeb..99821be7cb 100644
--- a/tizen/src/emulator_common.h
+++ b/tizen/src/emulator_common.h
@@ -38,6 +38,7 @@
 #ifndef __EMULATOR_COMMON_H__
 #define __EMULATOR_COMMON_H__
 
+#include <string.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <stdbool.h>
diff --git a/tizen/src/skin/maruskin_operation.c b/tizen/src/skin/maruskin_operation.c
index 7be2597204..2a1aa64550 100644
--- a/tizen/src/skin/maruskin_operation.c
+++ b/tizen/src/skin/maruskin_operation.c
@@ -120,7 +120,7 @@ void do_mouse_event(int button_type, int event_type,
         "host=(%d, %d), x=%d, y=%d, z=%d\n",
         button_type, event_type, origin_x, origin_y, x, y, z);
 
-#ifndef CONFIG_USE_SHM
+#if !defined(CONFIG_USE_SHM) && defined(CONFIG_SDL)
     /* multi-touch */
     if (get_emul_multi_touch_state()->multitouch_enable == 1) {
         maru_finger_processing_1(event_type, origin_x, origin_y, x, y);
@@ -193,7 +193,7 @@ void do_keyboard_key_event(int event_type,
         "state_mask=%d, key_location=%d\n",
         event_type, keycode, state_mask, key_location);
 
-#ifndef CONFIG_USE_SHM
+#if !defined(CONFIG_USE_SHM) && defined(CONFIG_SDL)
     if (get_emul_max_touch_point() > 1) {
         /* multi-touch checking */
         int state_mask_temp = state_mask & ~JAVA_KEYCODE_NO_FOCUS;
diff --git a/tizen/src/skin/maruskin_operation.h b/tizen/src/skin/maruskin_operation.h
index 317bfa0025..b434f6c324 100644
--- a/tizen/src/skin/maruskin_operation.h
+++ b/tizen/src/skin/maruskin_operation.h
@@ -30,8 +30,7 @@
 #ifndef MARUSKIN_OPERATION_H_
 #define MARUSKIN_OPERATION_H_
 
-#include "qemu-common.h"
-
+#include "stdint.h"
 
 extern int ret_hax_init;
 
@@ -45,7 +44,7 @@ typedef struct DetailInfo {
     int data_length;
 } DetailInfo;
 
-void start_display(uint64 handle_id,
+void start_display(uint64_t handle_id,
     unsigned int display_width, unsigned int display_height,
     double scale_factor, short rotation_type, bool blank_guide);
 
diff --git a/tizen/src/tethering/common.h b/tizen/src/tethering/common.h
index c9c2892f6a..3a882c8c5a 100644
--- a/tizen/src/tethering/common.h
+++ b/tizen/src/tethering/common.h
@@ -28,6 +28,8 @@
  *
  */
 
+#include "qemu/queue.h"
+
 typedef struct input_device_list {
     int type;
     void *opaque;
diff --git a/tizen/src/tethering/encode_fb.c b/tizen/src/tethering/encode_fb.c
index a8f46032f3..7c724b0543 100644
--- a/tizen/src/tethering/encode_fb.c
+++ b/tizen/src/tethering/encode_fb.c
@@ -33,6 +33,7 @@
 #include <webp/encode.h>
 #endif
 
+#include "emulator_common.h"
 #include "emul_state.h"
 #include "skin/maruskin_operation.h"
 #include "encode_fb.h"
diff --git a/tizen/src/tethering/sensor.c b/tizen/src/tethering/sensor.c
index 43f7a0ac59..5516575808 100644
--- a/tizen/src/tethering/sensor.c
+++ b/tizen/src/tethering/sensor.c
@@ -35,12 +35,12 @@
 #define EISCONN WSAEISCONN
 #endif
 
-#include "qemu-common.h"
 #include "qemu/main-loop.h"
 #include "qemu/sockets.h"
 #include "ui/console.h"
 #endif
 
+#include "emulator_common.h"
 #include "emul_state.h"
 
 #include "sensor.h"
diff --git a/tizen/src/tethering/touch.c b/tizen/src/tethering/touch.c
index 296b656cfe..391a670c30 100644
--- a/tizen/src/tethering/touch.c
+++ b/tizen/src/tethering/touch.c
@@ -28,6 +28,7 @@
  *
  */
 
+#include "emulator_common.h"
 #include "emul_state.h"
 #include "common.h"
 #include "touch.h"
diff --git a/vl.c b/vl.c
index 5c83ae3c7e..3da782a66a 100644
--- a/vl.c
+++ b/vl.c
@@ -4540,6 +4540,32 @@ int main(int argc, char **argv, char **envp)
     if (qemu_opts_foreach(qemu_find_opts("device"), device_init_func, NULL, 1) != 0)
         exit(1);
 
+#ifdef CONFIG_VIGS
+    // To support legacy VIGS options
+    if (enable_vigs) {
+        PCIBus *pci_bus = (PCIBus *) object_resolve_path_type("", TYPE_PCI_BUS, NULL);
+        PCIDevice *pci_dev = pci_create(pci_bus, -1, "vigs");
+        if (vigs_backend) {
+            qdev_prop_set_string(&pci_dev->qdev, "backend", vigs_backend);
+        } else {
+            qdev_prop_set_string(&pci_dev->qdev, "backend", "gl");
+        }
+        qdev_prop_set_string(&pci_dev->qdev, "wsi", "wsi0");
+        qdev_init_nofail(&pci_dev->qdev);
+    }
+#endif
+#ifdef CONFIG_YAGL
+    // To support legacy YaGL options
+    if (enable_yagl) {
+        PCIBus *pci_bus = (PCIBus *) object_resolve_path_type("", TYPE_PCI_BUS, NULL);
+        PCIDevice *pci_dev = pci_create(pci_bus, -1, "yagl");
+        if (enable_vigs) {
+            qdev_prop_set_string(&pci_dev->qdev, "wsi", "wsi0");
+        }
+        qdev_init_nofail(&pci_dev->qdev);
+    }
+#endif
+
     net_check_clients();
 
     ds = init_displaystate();
@@ -4555,6 +4581,7 @@ int main(int argc, char **argv, char **envp)
         break;
 #endif
 #if defined(CONFIG_MARU)
+#if defined(CONFIG_SDL)
     case DT_MARU:
         maru_display_init(ds);
         if (skin_disabled == 1) {
@@ -4566,6 +4593,7 @@ int main(int argc, char **argv, char **envp)
         start_skin();
         break;
 #endif
+#endif
 #if defined(CONFIG_SDL)
     case DT_SDL:
         sdl_display_init(ds, full_screen, no_frame);
@@ -4610,31 +4638,6 @@ int main(int argc, char **argv, char **envp)
         qemu_spice_display_init();
     }
 #endif
-#ifdef CONFIG_VIGS
-    // To support legacy VIGS options
-    if (enable_vigs) {
-        PCIBus *pci_bus = (PCIBus *) object_resolve_path_type("", TYPE_PCI_BUS, NULL);
-        PCIDevice *pci_dev = pci_create(pci_bus, -1, "vigs");
-        if (vigs_backend) {
-            qdev_prop_set_string(&pci_dev->qdev, "backend", vigs_backend);
-        } else {
-            qdev_prop_set_string(&pci_dev->qdev, "backend", "gl");
-        }
-        qdev_prop_set_string(&pci_dev->qdev, "wsi", "wsi0");
-        qdev_init_nofail(&pci_dev->qdev);
-    }
-#endif
-#ifdef CONFIG_YAGL
-    // To support legacy YaGL options
-    if (enable_yagl) {
-        PCIBus *pci_bus = (PCIBus *) object_resolve_path_type("", TYPE_PCI_BUS, NULL);
-        PCIDevice *pci_dev = pci_create(pci_bus, -1, "yagl");
-        if (enable_vigs) {
-            qdev_prop_set_string(&pci_dev->qdev, "wsi", "wsi0");
-        }
-        qdev_init_nofail(&pci_dev->qdev);
-    }
-#endif
 
     if (foreach_device_config(DEV_GDB, gdbserver_start) < 0) {
         exit(1);