From: Kateryna Fesyna Date: Mon, 23 Jun 2014 09:18:59 +0000 (+0200) Subject: edje: Edje_Edit - add missed iterator and object deletion in _delete_play_actions... X-Git-Tag: upstream/1.10.0+1149+ga3a15b1~496 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7c8764bf3976398ac83b533433e86838c0eaa0e0;p=platform%2Fupstream%2Fefl.git edje: Edje_Edit - add missed iterator and object deletion in _delete_play_actions() function Summary: this commit adds missed eina_iterator_free() and evas_object_del() calls in _delete_play_actions() functions. @feature Reviewers: cedric, Hermet, seoz, raster, reutskiy.v.v, tasn Reviewed By: reutskiy.v.v CC: reutskiy.v.v, cedric Differential Revision: https://phab.enlightenment.org/D1059 Signed-off-by: Cedric BAIL --- diff --git a/src/lib/edje/edje_edit.c b/src/lib/edje/edje_edit.c index aa84165..a908b32 100644 --- a/src/lib/edje/edje_edit.c +++ b/src/lib/edje/edje_edit.c @@ -971,11 +971,17 @@ _delete_play_actions(Evas_Object *obj, const char* name, int action_type, Eet_Fi return EINA_FALSE; if (!edje_object_file_set(eeo, ed->file->path, pce->entry)) - continue; + { + evas_object_del(eeo); + continue; + } programs_list = edje_edit_programs_list_get(eeo); if (!programs_list) - continue; + { + evas_object_del(eeo); + continue; + } eed = eo_data_scope_get(eeo, EDJE_CLASS); for (i = 0; i < eed->collection->patterns.table_programs_size; i++) @@ -1008,7 +1014,10 @@ _delete_play_actions(Evas_Object *obj, const char* name, int action_type, Eet_Fi } if (is_collection_changed) _edje_edit_collection_save(eetf, eed->collection); + evas_object_del(eeo); } + + eina_iterator_free(it); return EINA_TRUE; }