From: Michael Chan Date: Mon, 24 Jan 2011 12:59:02 +0000 (+0000) Subject: bnx2: Always set ETH_FLAG_TXVLAN X-Git-Tag: v3.0~1794^2~119 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=7c8104774e59549c37dd1cb0a8ec4f131094664c;p=platform%2Fkernel%2Flinux-amlogic.git bnx2: Always set ETH_FLAG_TXVLAN TSO does not work if the VLAN tag is in the packet (non-accelerated). We may be able to remove this restriction in future firmware. Reported-by: Eric Dumazet Signed-off-by: Michael Chan Signed-off-by: David S. Miller --- diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index df99edf..99e7652 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -7553,6 +7553,10 @@ bnx2_set_flags(struct net_device *dev, u32 data) !(data & ETH_FLAG_RXVLAN)) return -EINVAL; + /* TSO with VLAN tag won't work with current firmware */ + if (!(data & ETH_FLAG_TXVLAN)) + return -EINVAL; + rc = ethtool_op_set_flags(dev, data, ETH_FLAG_RXHASH | ETH_FLAG_RXVLAN | ETH_FLAG_TXVLAN); if (rc)